5E - Token Height Indicator

[DwightLee]

Found the error.... it is an SUE problem, not sure there is going to be a fix for that.

[bmos]

Not sure if this is useful to you, GKEnialb, but thought you should see part of new FG changelog:
[DEV] Consolidated token initial onAdd/onMove event into a single onAdd event with correct token position.
...
[DEV] Token onDrag event was not triggering. Fixed.

[GKEnialb]

@bmos, thanks for that.

@DwightLee, glad you found the problem, but sorry there may not be a fix for you. What is SUE? If there's anything I can do on my side, I'd be happy to investigate.

[bmos]

disregard for now

[Svandal]

There is a compatability issue that happened again now with the latest live version of fantasy grounds unity.
A compatability issue between this extension and "combat modifier calculation" extension. I have reported it before also, but it had been fixed a couple of times.
I am not sure if it is the latest fantasy grounds version or one of the latest "token height" extension versions that has caused this issue to come back again. "Combat modifier calculation" has not been updated so it is not a update from that extension at least.

A small summary:
I get this error message:
Handler error: [string "campaign/scripts/image.lua"]:147: attempt to index local 'targetToken' (a nil value)

I added a bunch of debug.chat commands in the "combat modifier calculation" to see when the error happens. The error happens when the extension calls this function (in the "manager_action_attack_custom.lue" file):
local adjTokens = srcImage.getTokensWithinDistance({x=tgtCoord.x, y=(tgtCoord.y * -1)}, 5);

See details here
https://www.fantasygrounds.com/forum...l=1#post617619

Not sure where the error lies.

[GKEnialb]

Sorry - I've been out of town. Do you have tokens on the map that aren't on the combat tracker? Basically targetToken is coming from looking up each combatant node in the combat tracker and isn't finding one of them. I can protect against that easily enough, but want to make sure I'm not ignoring a valid token.

[Svandal]

Sorry - I've been out of town. Do you have tokens on the map that aren't on the combat tracker? Basically targetToken is coming from looking up each combatant node in the combat tracker and isn't finding one of them. I can protect against that easily enough, but want to make sure I'm not ignoring a valid token.

Yes, I am sure everything is in the combat tracker.

[bmos]

I think you are just running into a new 4.1.5 bug: https://www.fantasygrounds.com/forum...ion-miss-match

[Blackfoot]

I realize that you've probably tested your extension with all the Rulesets that you've enabled for it, but is there any real reason to restrict it to a limited set of Rulesets?

[GKEnialb]

Mainly because I started with just 5E and only added as requests came in and I could test to see if there were any ruleset-specific peculiarities (particularly with diagonals). That being said, I probably have enough rulesets now that it should work for any of them - I'll remove that restriction. Now to find a mod to get the name of this thread changed.

Edit: Live on the Forge