My expiring of effect call is now failing in TEST - works in LIVE

[SilentRuin]

I should note that even with the sample campaign I gave you - where I don't override parseNPCpower - you could easily put a printstack in your ruleset version and see that when I do the polymorph it never gets called - hence blank. Using equipped effects I can do my own printstack as in that one I do override pareseNPCpower. But in both cases, the behavior no longer triggers pareseNPCpower in your new way of doing things triggered by the drop only.

[SilentRuin]

I did more digging it looks like addNPC in LIVE used to call parseNPCPower directly and addNPC in TEST no longer does. Nor does it trigger it when addNPC is called directly. Not all CT node addition occurs due to a drop. Some are due to direct calls to addNPC.

[Moon Wizard]

In the core ruleset, there are no direct calls to addNPC.

If you need to call something analogous to addNPC, then you would you would call need to make a call like this with the new code:

	local tCustom = { sClass = "npc", sRecord = [sourcepath] };
	CombatRecordManager.onRecordTypeEvent("npc", tCustom);

Regards,
JPG

[SilentRuin]

In the core ruleset, there are no direct calls to addNPC.

If you need to call something analogous to addNPC, then you would you would call need to make a call like this with the new code:

	local tCustom = { sClass = "npc", sRecord = [sourcepath] };
	CombatRecordManager.onRecordTypeEvent("npc", tCustom);

Regards,
JPG

That Solved it - much appreciated. Just need to figure out the infinite loop as my only "known" problem left.

Replace any addNPC calls with the above and all my CT action lines are there.

[SilentRuin]

Infinite loop solved, per Moon Wizard suggestion, replaced CombatManager.setCustomAddNPC(onHostAddNPC) call with the following:

In onDesktopInit...

		savedOldFn = CombatRecordManager.getRecordTypePostAddCallback("npc");
		CombatRecordManager.setRecordTypePostAddCallback("npc", onNPCPostAdd);

With function...

function onNPCPostAdd(tCustom)
	if savedOldFn then
		savedOldFn(tCustom); -- assume if something there they call CombatManager2.onNPCPostAdd
	else
		CombatManager2.onNPCPostAdd(tCustom);
	end
	local nodeCT = tCustom.nodeCT;

... My Stuff ...

[Moon Wizard]

There was a bug in CombatRecordManager.getRecordTypePostAddCallback that I just fixed in the beta Test channel.

You shouldn't need the CombatManager2.onNPCPostAdd(tCustom); backup call any more.

function onNPCPostAdd(tCustom)
	if savedOldFn then
		savedOldFn(tCustom);
	end
	local nodeCT = tCustom.nodeCT;

... My Stuff ...

Regards,
JPG

[SilentRuin]

There was a bug in CombatRecordManager.getRecordTypePostAddCallback that I just fixed in the beta Test channel.

You shouldn't need the CombatManager2.onNPCPostAdd(tCustom); backup call any more.

function onNPCPostAdd(tCustom)
	if savedOldFn then
		savedOldFn(tCustom);
	end
	local nodeCT = tCustom.nodeCT;

... My Stuff ...

Regards,
JPG

I assume if it ever did come back null in this check I'd still have to call the CombatManager2.onNPCPostAdd - though I understand you've fixed it so it should not.

[SilentRuin]

As this is my grab bag thread of things I've had to fix in my extensions for TEST - I figured I'd mention this one. Make sure you replace addNPC calls etc. with CombatRecordManager.onRecordTypeEvent - or you will pay for it in subtle ways.