Thread: 5E - Token Height Indicator
-
January 26th, 2022, 23:15 #441
Refined fixes. But really getting scary in what I have to do to actually get it not to process the duplicate mouse moves yet still react even when just the height changes. Took a lot of trial and error (mostly through stupidity and type-o's) but I think this "might" work. Don't use it without testing it in all ways you can think of. If you use it. But this finally fixed the lag due to processing 50 times if I hover over a token. Now it just does once. Or when height changes. To see this vs current just put a Debug.console("*") in after the super calls to see how many times onMousePointer is hit - then imagine all those calls to loop over stuff - even to just find out there is no height difference (previous changes). I removed the version in previous post so there is no confusion. Again - this one you really have to test as its... RISKY BUSINESS in the extension world!
Last edited by SilentRuin; January 27th, 2022 at 05:14.
Free(Forums/Forge) Extension(FGU 5E):
Paid (Forge) Extension(FGU 5E):
-
January 26th, 2022, 23:51 #442bmos' extensions
he/them
-
January 26th, 2022, 23:59 #443Free(Forums/Forge) Extension(FGU 5E):
Paid (Forge) Extension(FGU 5E):
-
January 27th, 2022, 02:42 #444
Thanks again. I'll give it a thorough testing, but may not get a full suite done until Sunday.
-
January 27th, 2022, 05:14 #445Free(Forums/Forge) Extension(FGU 5E):
Paid (Forge) Extension(FGU 5E):
-
January 27th, 2022, 13:17 #446bmos' extensions
he/them
-
January 30th, 2022, 00:37 #447
New version with significant performance improvements (may not notice the improvements without a large number of tokens on the map).
bmos, since you were interested, the places with the most improvements are where you find an OptData reference in image.lua and token_height_indication.lua (don't update measurements when nothing changes) and the replacement of the override of getWidgetList in token_height_indication.lua with a call to refreshHeights from onInit in image.lua (don't update heights lots and lots and lots and lots of times - the function was a workaround I had to ensure the heights being updated when the map loaded before I overrode image.lua). There are a few other things scattered about as well. You aura extension actually works pretty well with the giant test campaign - I was worried that the other calls I overrode would have similar performance impacts without a workaround, but luckily that doesn't seem to be the case. Let me know if you'd like the giant test campaign (~130 tokens ready for a big battle).
Thanks again to SilentRuin for his contributions in this!
-
January 30th, 2022, 01:15 #448
Last edited by SilentRuin; January 30th, 2022 at 01:23.
Free(Forums/Forge) Extension(FGU 5E):
Paid (Forge) Extension(FGU 5E):
-
February 10th, 2022, 01:58 #449
- Join Date
- Mar 2020
- Posts
- 54
The arrow is not showing the correct distance for me. It isn't taking height into account at all. I just started using this extension, so doubled checked the front page to ensure it is supposed to affect the arrow.
Tested with no other extensions. 5E.
Thanks
-
February 10th, 2022, 02:07 #450
Let me know your ruleset and the three dimensions between the origin token and target token. Also note the calculations on the first post, as if you're not using the raw measurements, it may not be intuitive what to expect (but does match the spirit of the various rulesets). Haven't had any other reports of things not working, so just want to narrow down what it could be. Thanks.
Thread Information
Users Browsing this Thread
There are currently 1 users browsing this thread. (0 members and 1 guests)
Bookmarks