PF2E Playlist
Page 20 of 30 First ... 101819202122 ... Last
  1. #191
    Ah, yes. I just checked. Thanks for testing this. Too bad for us PF2 groups, but still useful.

  2. #192
    Nice extension. I did find the conflict that was happening mentioned before with the onDrop error. We both have extensions, Critically Awesome Essentials and Token Height extension, that both add to image_record_step... so, I figured out the deconflict, is you wished to make them work together nicely.

    in your /campaign/scripts/image.lua you can add the following script to the bottom of the file.

    Code:
    function onDrop(x, y, draginfo)
    	local custData = {};
    	custData.x = x ;
    	custData.y = y ;
    	custData.imgCtrl = self ;
    	if  draginfo.getType() == "token" then
    		draginfo.setCustomData(custData);
    	end;
    end
    Additionally I am attaching a copy of your extension with the deconflict installed in it. I also added the version notes and advanced the version to 3.7

    V/r,
    Diablobob
    Last edited by Diablobob; May 14th, 2021 at 05:05.

  3. #193
    GKEnialb's Avatar
    Join Date
    Jul 2017
    Location
    Castle Rock, CO
    Posts
    285
    Thanks! I've incorporated that into v3.7. I also reverted a change to extension.xml, which hopefully will fix other instances of randomly disappearing image functions (see Functions from image.lua disappearing). Not sure about the faction dropping thing - maybe one of these will fix that for free...

  4. #194
    GKEnialb's Avatar
    Join Date
    Jul 2017
    Location
    Castle Rock, CO
    Posts
    285
    Quote Originally Posted by Weissrolf View Post
    Thanks for the extension! I patched the XML file to include Pathfinder 2 and it seems to work properly.

    Diagonal target range calculation confuses me, though. Why is this 10 ft instead of 5 ft?

    I added PFRPG2 in v3.7. For variant diagonals, I extend the 2D calculation of long leg + 1/2 short leg to be longest leg + 1/2 of both shorter legs. In this case (5x5x5), it's 5 + 10/2 = 10.

  5. #195
    So for the calculation, are using the a squared + b squared = c squared?... cause it would be easy with height squared + map token distance squared = square of calculated distance

    If you want to look into this let me know and I can get you the callouts if you have a tough time finding them...

    I was just curious if your method

  6. #196
    GKEnialb's Avatar
    Join Date
    Jul 2017
    Location
    Castle Rock, CO
    Posts
    285
    For raw measurements (House Rule option in 5E, map option in other rulesets), I use the actual distance (sqrt(x^2+y^2+z^2). For the 5E standard, I extend the 2D method by taking the max in each dimension. For the 5E variant / normal diagonals for most other rulesets, I use long leg + half of each shorter leg (again extending the 2D formula). If you want the exact measurements, it's available in the raw distances option in the maps. If you use the default for the rulesets, though, I want to mimic the spirit as much as possible.

  7. #197
    GKEnialb's Avatar
    Join Date
    Jul 2017
    Location
    Castle Rock, CO
    Posts
    285
    With more help from Moon Wizard, this should now work on maps made full screen or sent the the background. v3.8 uploaded.

  8. #198
    GKEnialb this is a slick extension; you've been putting in a ton of work for what probably seemed like a simple idea at the outset! Thanks for this!

    I want to also report a minor bug with FGU 4.1 and v3.8 of this extension. With only this extension enabled, I can no longer use the faction helmets to drag a group of tokens from the CT to a map. If I disable this extension, it works fine.

    Attached is a gif demonstration as well as the campaign if you need it to help debug.
    Attached Images Attached Images
    Attached Files Attached Files

  9. #199
    Ran into this issue tonight. With this and Batch 9 Spell tokens ext only in a clean 5e build, I can not place spell tokens on a map. It silently fails. Turn off token height and I can place spell tokens. Did not expect that. Any thoughts? I am posting on Batch 9s thread as well. Thanks!

    With both on - spell tokens cannot be placed. (screen1)


    With token height off - spell tokens can be placed (screen2)
    Attached Images Attached Images
    Last edited by nephranka; May 17th, 2021 at 00:56.

  10. #200
    Quote Originally Posted by nephranka View Post
    Ran into this issue tonight. With this and Batch 9 Spell tokens ext only in a clean 5e build, I can not place spell tokens on a map. It silently fails. Turn off token height and I can place spell tokens. Did not expect that. Any thoughts? I am posting on Batch9s thread as well. Thanks!

    With both on - spell tokens cannot be placed. (screen1)


    With token height off - spell tokens can be placed (screen2)
    I've taken a look at the issues and its a missing super call from the 'diablobob' code in 'image.lua', without the 'super.onDrop' you loose things like 'drag all party tokens to map' from the combat tracker.

    -pete

    Code:
    -- From diablobob
    function onDrop(x, y, draginfo)
    	if draginfo.getType() == "token" then
    		local custData = {};
    		custData.x = x ;
    		custData.y = y ;
    		custData.imgCtrl = self ;
    		draginfo.setCustomData(custData);
    	end;
    
    	if super and super.onDrop then
    		return super.onDrop(x, y, draginfo);
    	end
    end
    And you should probably not double call 'super.onInit' during your 'onInit' function.

    Code:
    function onInit()
    	if super and super.onInit then
    		super.onInit()
    	end
    
    	getDistanceBetween_orig = Token.getDistanceBetween
    	Token.getDistanceBetween = getDistanceBetween
    end
    Attached Files Attached Files
    Last edited by bratch9; May 17th, 2021 at 20:57. Reason: attached adjusted file

Thread Information

Users Browsing this Thread

There are currently 4 users browsing this thread. (3 members and 1 guests)

  1. BlazingAzureCrow,
  2. estrolof,
  3. TheoGeek

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
DMsGuild Classic

Log in

Log in