-
January 6th, 2022, 16:28 #121My extensions for 3.5e and Pathfinder
Bug reports please here
-
January 11th, 2022, 02:10 #122
Seems to be an incompatibility with the latest version of "Extended Automation and Overlays" (released today on the Forge). Any attempt to roll an attack against a target gets the following Lua error:
[ERROR] Script execution error: [string "scripts/manager_action_attack.lua"]:361: attempt to perform arithmetic on local 'nADVATK' (a nil value)
If I unload the "Advanced Effects" extension attacks work properly. I am suspecting the Extended Automation and Overlays is expecting some extra return data from some functions it overrides that maybe Advanced Effects also overrides? But that's just a guess on my part - I didn't look at the code yet.
Cheers,
Brian
-
January 11th, 2022, 02:36 #123
EDIT: scratch what I wrote below. There's more changes needed than that to get the two extensions to coexist.
I looked at it in a bit more detail. Seems the function "getEffectsByType_kel()" in manager_AE.lua needs a small update comparing it to the the getEffectByType() function in Kel's extension. A few function calls (checkConditional()) now has a couple extra arguments. I just merged those lines into a test copy of Advanced Effects and it appears to work -at least attacks no longer throw errors, but I haven't checked the numbers extensively for other potential breakages.
Cheers,
BrianLast edited by MostTornBrain; January 11th, 2022 at 02:53.
-
January 11th, 2022, 03:36 #124
Ok, I got the two extensions to work together. There was a second function, hasEffect_kel() which now needed to return 2 values rather than one, and the calls to checkConditional needed to be updated similary to what was needed to be done for getEffectsByType_kel(). Comparing to Kel's implementation into manager_effects_35E.lua was what I used as a reference.
Cheers,
Brian
-
January 11th, 2022, 15:21 #125
Indeed, I need to update a couple extensions now that Kel has had a chance to push updates.
I just updated my Extended Natural, Shield, and Armor AC Bonus Types Extension and hope to get to Advanced Effects tomorrow. Thanks for taking the time to report the issue!bmos' extensions
he/them
-
January 18th, 2022, 20:58 #126
- Join Date
- Mar 2020
- Location
- San Diego, CA
- Posts
- 49
+1 to this - seeing the same issue. Both of these extensions are SUPER handy.
-
January 18th, 2022, 21:12 #127
-
January 18th, 2022, 21:18 #128bmos' extensions
he/them
-
January 18th, 2022, 21:26 #129
- Join Date
- Mar 2020
- Location
- San Diego, CA
- Posts
- 49
Sorry to say that is NOT my experience. Just did an update and reloaded... still kicking the same error.
To see if it would help, I disabled the extension in the Forge, then re-enabled it.
According to the load screen script it looks like I'm using version v1.7-hotfix 1 -- is that the latest?
-
January 18th, 2022, 21:31 #130My extensions for 3.5e and Pathfinder
Bug reports please here
Thread Information
Users Browsing this Thread
There are currently 2 users browsing this thread. (0 members and 2 guests)
Bookmarks