-
June 4th, 2018, 13:13 #11
All the above posts that are making suggestions from packaging to ease of use are just that - suggestions on how to improve things. Not everyone has the same level of programming ability or familiarity with how Fantasy Grounds works. And sometimes its just another set of eyes giving a different perspective on a solution. Every one of the posters is well aware that developers are doing this in their free time. The OP has made several posts requesting help, advice or guidance and the above replies were useful.
-
June 4th, 2018, 14:08 #12
- Join Date
- Jan 2015
- Location
- Grand Rapids, MI
- Posts
- 136
Sorry, when I saw the first post I knew what had happened. I was out all night. I've updated the uploaded file.
Last edited by Tielc; June 4th, 2018 at 14:16.
-
June 4th, 2018, 14:11 #13Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!
-
June 4th, 2018, 15:46 #14---
Fantasy Grounds AD&D Reference Bundle, AD&D Adventure Bundle 1, AD&D Adventure Bundle 2
Documentation for AD&D 2E ruleset.
Custom Maps (I2, S4, T1-4, Barrowmaze,Lost City of Barakus)
Note: Please do not message me directly on this site, post in the forums or ping me in FG's discord.
-
June 4th, 2018, 16:26 #15
- Join Date
- Jan 2015
- Location
- Grand Rapids, MI
- Posts
- 136
I've gotten through a cup of coffee this morning, something I should always do before tackling any task for the day. Just saying. I'm going to incorporate the entire character sheet to eliminate the need to modify the 5e ruleset. Assuming this doesn't come with any other complications, I'll update the original post with this new extension.
-
June 4th, 2018, 16:55 #16
The main complication is that it means possibly more work to make the extension compatible if (when) future FG versions are released that affect the XML in question. That is, the extension will need to be changed to use the new XML, plus the changes needed for the extension, to keep compatibility with the latest FG release.
Or, there are more chances of a clash with other extensions.
As you noted in post #1, the ideal solution is to use the merge rules, but you can't because the label control is not named - hopefully your request to add this will be addressed in the next release.
If merge rules are not possible, then the next step is to override the whole <windowclass> entry where the control resides. The rest of the XML file where that <windowclass> is specified is not needed, nor is "the entire character sheet". The more information you include, the more chances you have of a future FG release breaking it, or the extension clashing with another community extension.
My recommendation would be to just include the modified <windowclass name="charsheet_main"> XML section in your extension, as I mentioned in post #6 of this thread.Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!
-
June 4th, 2018, 21:54 #17
- Join Date
- Jan 2015
- Location
- Grand Rapids, MI
- Posts
- 136
I've updated the download in the original post removing the need to make any changes to the 5e Ruleset. I'm also rendering a new video showing how this extension works.
-
June 4th, 2018, 21:55 #18
- Join Date
- Jan 2015
- Location
- Grand Rapids, MI
- Posts
- 136
This actually required a decent amount of work. As doing a merge, I was able to leave out most of the xml for even the entities I've modified, including their scripts. I had to go back and spend a decent amount of time making sure I hadn't missed anything. Now, for when I deal with this in the future. If I'm editing an xml class that itself is already doing a merge, and I want to completely override the 5e ruleset implementation, how would I handle that? So I don't want the 5e ruleset implementation, but maybe I need to the CoreRPG stuff that's in that class already?
-
June 4th, 2018, 22:19 #19Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!
-
June 5th, 2018, 00:14 #20
@Celestian, was referring to Tren here, I'm not behind the whole enforcing standardization from free contributions. There's a place for that, but FG is more of a loose confederation. Sure there's a bug that kept it from working, could have done without the pontificating.
Last edited by Ken L; June 5th, 2018 at 00:17.
Thread Information
Users Browsing this Thread
There are currently 1 users browsing this thread. (0 members and 1 guests)
Bookmarks