Fantasy Grounds Fridays Pre
Page 2 of 2 First 12
  1. #11
    I just want to say that this extension is incredibly useful.
    Not sure how I coped without it. Thanks!
    bmos' extensions
    he/him | Discord Tag: wil.thieme#3396

  2. #12
    A suggestion: this would also be great to have in the parcel editor.
    bmos' extensions
    he/him | Discord Tag: wil.thieme#3396

  3. #13
    Just noticed the xml file doesn't have
    Code:
    merge="join"
    specified.
    Probably a good idea to add that.

    EDIT: looks like one other change is needed for this to work:
    Code:
    			<button_record_isidentified name="isidentified">
    needs to be
    Code:
    			<button_record_isidentified name="identifyitem">
    Last edited by bmos; June 14th, 2021 at 16:06.
    bmos' extensions
    he/him | Discord Tag: wil.thieme#3396

  4. #14
    Quote Originally Posted by bmos View Post
    Just noticed the xml file doesn't have
    Code:
    merge="join"
    specified.
    Probably a good idea to add that.
    Can you explain what that does? I don't mind editing it, but no idea what it does.

  5. #15
    Quote Originally Posted by MrDDT View Post
    Can you explain what that does? I don't mind editing it, but no idea what it does.
    Code:
    	<windowclass name="ps_parcelitem">
    should be
    Code:
    	<windowclass name="ps_parcelitem" merge="join">
    This is important for compatibility with future updates and other extensions.

    EDIT: specifically here the extension appears to be re-configuring the entire party inventory list. This could be an issue if you have another extension that also modifies the party inventory.
    Last edited by bmos; March 23rd, 2021 at 13:22.
    bmos' extensions
    he/him | Discord Tag: wil.thieme#3396

  6. #16
    The merge="join" means that the window class definition does not fully override the existing definition, but layers on top of it. You only want to use that if you want to modify some of the existing behavior or add/remove a few fields, instead of replacing the whole thing. This prevents you from having to redefine existing fields/behaviors, and allows better compatibility with updates and other extensions.

    However, you should understand how it should be defined in order to utilize it by looking at the developer's guide on the wiki; as well as examples in the 3.5E and 5E rulesets. Otherwise, it may not help at all.

    Regards,
    JPG

  7. #17
    This is brilliant, thank you.
    Cuius testiculus habes, habeas cardia et cerebellum.
    When you have their full attention in your grip, their hearts and minds will follow."


    Terry Pratchett [RIP] - Small Gods

  8. #18
    This extension is fantastic, thank you!

  9. #19
    Because I also have an extension that modifies this windowclass, I have made a more compatible version of this extension which doesn't replace the entire windowclass.

    EDIT: reuploaded to also make "Assigned" label line up perfectly with the fields
    Attached Files Attached Files
    Last edited by bmos; June 14th, 2021 at 20:01.
    bmos' extensions
    he/him | Discord Tag: wil.thieme#3396

  10. #20
    Ohhh my goodness. I never knew about this before, such a great extension! Thank you!

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Joshua Stream Pre

Log in

Log in