Extension Question

[Bidmaron]

It has been a while since I wrote an extension, and I just need to check because I cannot locate it in the developer documentation:

If I override a manager routine in my extension lua include file, that code will replace the code in the manager, right? And there is no way to invoke the original code (using super or some such) if I just want to intercept the call, check some parameters, and pass control back to the original unless it meets some very specific parameter criteria, right?

[dulux-oz]

Yeap, unlike with the XML templates, lua functions cannot be "supered" from an Extension back to a Ruleset - the whole lua file needs to be reproduced (with appropriate changes) in the Extension

Does that answer you question?

Cheers

[Bidmaron]

That's what I thought, Dulux, but if you need to replace a routine in a manager (in this case, the Table.Manager), do I need to replace each routine in there, or just the ones I need to replace? Since a manager is accessed through Table.xxxx, where xxxx is the name of the routine, how do I even replace it? My guess is that I have to override the entire Manager declaration in my xml so that "Manager" refers to my file and not the original file. So, I think I have to redirect the Table manager in my own xml declaration and duplicate the entire Table.Manager file just to change a couple of lines within one routine. Can you confirm?

[dulux-oz]

Yes, that's pretty much what you have to do.

I suspect that's one reason why there are so many small (<50 lines) lua files - so that they can be "swapped out" easier than if there was only a few big ones.

[Moon Wizard]

Actually, I think that there have been a few extensions that have successfully replaced individual functions within a ruleset. As long as the functions are not defined as local (which none are), then you should be able to replace them. The only caveat is that you still need to be watchful of code updates in the base code, and cross-extension clashes.

function onInit()
  TableManager.performRoll = newPerformRoll;
end

function newPerformRoll(...)
  ...
end

Regards,
JPG

[dulux-oz]

Now that's an interesting idea - and it'll cut down on the code-size as well - hmmmmm?!

That's for that Moon

[Bidmaron]

Actually, I think that there have been a few extensions that have successfully replaced individual functions within a ruleset. As long as the functions are not defined as local (which none are), then you should be able to replace them. The only caveat is that you still need to be watchful of code updates in the base code, and cross-extension clashes.

....

Regards,
JPG

Thanks, MW. It really doesn't make much difference, because you still have to be mindful if you copy the whole file. In fact, it may be less likely that one routine is affected in a change than anything in a whole file. That override trick you mentioned: I never would have come up with that without your input. Muchas gracias, my friend!

[Andraax]

If you just need a wrapper around the original code, save off the current routine and call it. This emulates a call to a base class function. This way you'll get changes in the underlying code as well...

function onInit()
  originalRoll = TableManager.performRoll;
  TableManager.performRoll = newPerformRoll;
end

function newPerformRoll(...)
  ...
  originalRoll(...);
  ...
end

(Code has not been tested, but *should* work... :-D )

[dulux-oz]

You realize now I've got to go back through all my code and redo it all, don't you?!

[Nickademus]

You realize now I've got to go back through all my code and redo it all, don't you?!

You realize now that you have to figure out the best way to do this and make a tutorial video for the rest of us.