New Extension: TheoGeek's Improved Critical

[TheoGeek]

I just got this when rolling critical damage, and even though the dice rolled, no results came out in the chat window.

Script Error: [string "scripts/ImprovedCritical.lua"]:217: bad argument #1 to 'ipairs' (table expected, got nil)Attachment 34008

Hmmm, I downloaded that extension from the link in this thread, and started a new campaign with only that extension loaded and did not get that error. I also don't get that error with other extensions loaded. The only thing I could ask you to do is to "unzip" the extension and copy and paste the ImprovedCritical.lua file into a PM to me, and I'll take a look at it as soon as you do!

[KyoMibo]

You sir, are the best!
I have been using this rule for a while now, and I was stressing out how to use it in FGU.

[spoonhead]

Hmmm, I downloaded that extension from the link in this thread, and started a new campaign with only that extension loaded and did not get that error. I also don't get that error with other extensions loaded. The only thing I could ask you to do is to "unzip" the extension and copy and paste the ImprovedCritical.lua file into a PM to me, and I'll take a look at it as soon as you do!

Sorry for not getting back sooner. I rolled the extension back to an earlier version and it seemed to work again. I think it was also conflicting with this extension, https://www.fantasygrounds.com/forum...ns-v1-1-for-5E

[TheoGeek]

Sorry for not getting back sooner. I rolled the extension back to an earlier version and it seemed to work again. I think it was also conflicting with this extension, https://www.fantasygrounds.com/forum...ns-v1-1-for-5E

When I get home, I'll try it with that extension. Could you also try using version 2.4 with no other extensions loaded? Thanks!

[TheoGeek]

Sorry for not getting back sooner. I rolled the extension back to an earlier version and it seemed to work again. I think it was also conflicting with this extension, https://www.fantasygrounds.com/forum...ns-v1-1-for-5E

It is that extension - apparently, my extension and this one are incompatible. When only these two extensions are loaded, the rRoll structure that my extension gets is completely empty. Not sure where that's happening.

[TheoGeek]

It is that extension - apparently, my extension and this one are incompatible. When only these two extensions are loaded, the rRoll structure that my extension gets is completely empty. Not sure where that's happening.

OK...I got them to play nice together. I forced a load order so my ImprovedCritical extension loads after the Expanded Options extension. That fixes the crash, but it makes certain options from the Expanded Options extension do nothing (like "Attack Prettifier"), but it won't crash. I'm not sure what other side effects this may have, so I'm not going to upload it until I test it more with other extensions, but if you want a version, you can unzip the .ext file into the "extensions" folder, and edit the extension.xml file and change:

		<ruleset>
			<name>5E</name>
		</ruleset>

to

		<ruleset>
			<name>5E</name>
		</ruleset>
		<loadorder>
			1
		</loadorder>

Thanks!

[Broadcast Bard]

Hmmmm, I am having issues as well

https://i.imgur.com/vNvWLSV.png

https://i.imgur.com/e4VTqX1.png

https://i.imgur.com/yqtOMoN.png

I am trying to figure out which of these ext's isn't playing nice

I tried adding the load order to the .ext, but it didn't work.

[rigs19]

I was having all kinds of problems recently, resolved by uninstalling combat enhancer

[Beemanpat]

Is that pic a showing all the extensions you have loaded?

[Broadcast Bard]

Correct. I am working through them trying to narrow it down.