Page 1 of 8 123 ... Last
  1. #1

    [Extension] - Theogeek's Improved Critical (added icon by Glassstaff!)

    AUTHOR: Is v3.3.9 compatible.
    AUTHOR: Also Unity compatible.

    Download: ImprovedCritical.ext (rev 2.2)

    Hey all!

    So, I made this extension because I have had players be consistently disappointed in critical hits that do less damage than a standard hit. This extension only modifies the RAW to max the standard damage dice. All else is equal. For example, a half-orc with 18 strength (and no other bonuses) wielding a greatsword, if he crits, will do:

    MAX(2d6) + bonuses + 3d6 = 12 + 4 + 3d6

    The 3d6 is the crit damage: weapon dice (2d6) + the Half-Orc's Savage Attack bonus (1d6).

    That same half-orc with a greataxe does:
    Max(1d12) + 4 + 2d12 = 12 + 4+ 2d12.

    Without the extension, a half-orc critical with a greatsword might look like this:



    With the extension enabled, a half-orc critical with a greatsword might look like this:



    This extension ONLY guarantees that any critical attack will do at least the maximum damage of the weapon used (i.e. it raises the floor). It does not guarantee maximum damage (unless the options are set for it to do maximum damage), and it will never do greater maximum damage than a critical without this extension.

    Have fun with it and let me know if you have any additional ideas!

    Thanks to everyone who helped (check out http://www.fantasygrounds.com/forums...-a-global-rule if you want to follow the discussion as to how this came about.)
    Jeff.

    Option settings:

    Combat Settings:Improved Critical: Control = [Max Damage Dice | Max Critical Dice | Max Both | Off] - Defaults to "Max Damage Dice"
    - Max Damage Dice = All damage dice are maxxed, critical dice are rolled
    - Max Critical Dice = All critical dice are maxxed (including extra critical dice from features like Savage Critical, Brutal Critical, etc.), damage dice are rolled
    - Max Both = All damage AND all critical dice are maxxed
    - Off = revert to standard critical handler

    Combat Settings:Improved Critical: Include Effect Dice [On | Off] - Defaults to "On"
    - On = Damage dice from effects (such as sneak attack) are included in the calculations above
    - Off = Damage dice from effects are rolled as normal
    - Note: This option is dependent on the method chosen. For example, if the method is "Max Damage Dice" and this is "On", then the normal damage and the effect damage will be maxxed.
    - Note: If you select "Control = Max Both" and "Include Effect Dice = Yes", on a critical hit, you will do the maximum possible damage from all dice so be careful.

    Combat Settings:Improved Critical: Roll if Immune [On | Off] - Defaults to "Off"
    - On = Effectively bypasses this extension and rolls damage for a critical hit normally if the target has the "IMMUNE: critical" effect (i.e. no maxxing of anything regardless of other options selected for this extension)
    - Off = Uses other extension settings as set


    ---- Updated (30 November 2019) -----
    Version 2.2:
    - General cleanup
    - Replaced temporary bug fix from version 2.1 with an actual fix

    ---- Updated (28 November 2019) -----
    Version 2.1:
    - BUGFIX...this works, but is temporary. It will be replaced when the code is cleaner.

    ---- Updated (21 November 2019) -----
    Version 2.0:
    - Refactor to use onDamage instead of onDamageRoll
    - Add option to roll damage dice if target is immune to critical damage (basically ignores this extension)
    - Ignore this extension if the critical hit is due to the Chaos Bolt spell

    ---- Updated (15 July 2019) -----
    Version 1.9:
    - Fix coding error in wrapper

    ---- Updated (5 July 2019) ------
    Version 1.8:
    - Add icon created by Glassstaff - thanks Glassstaff!
    - Refactor the code to make it integrate better with existing ruleset:
    - Add wrapper function to conditionally call either the ImprovedCritical handler or the onDamageRoll handler
    - Remove code copied from ActionDamage.onDamageRoll and simply call that function when necessary

    ---- Updated (4 March 2019) ------
    Version 1.7:
    - Remove REROLL since that is not in the ActionDamage.onDamageRoll this code replaces.
    - Copy-n-Paste Max damage modifier code from ActionDamage.onDamageRoll.
    - Fix bug in options settings that prevented the ActionDamage.onDamageRoll routine from running when this extension is turned off.
    - Fix bug that included Effect damage, even if it was excluded, if "Max Both" was selected.

    Hopefully this is the last of the bugs. If you find something, please let me know!

    ---- Updated (2 March 2019) ------
    Version 1.6:
    - Make output more descriptive.

    Version 1.5:
    - Add support for manual MAX damage modifier (note, HALF already works)
    - Streamline code

    ---- Updated (25 February 2019) ------
    Improved Critical (new version numbering 1.4) - Add settings item controls as follows:
    Attached Images Attached Images
    Last edited by TheoGeek; November 30th, 2019 at 17:21. Reason: v 2.1 - refactor, add option to handle target crit immunity

  2. #2
    Trenloe's Avatar
    Join Date
    May 2011
    Location
    Denver, Colorado, USA (for a bit)
    Posts
    24,134
    Nice work!
    FG Con 15 Fantasy Grounds Online RPG Convention - Nov. 8-10, 2019
    Register at www.fg-con.com for all the latest info.

    Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!

  3. #3
    Thanks! It's pretty cool how you guys made it so extensible. That's pretty awesome!

  4. #4
    Zacchaeus's Avatar
    Join Date
    Dec 2014
    Location
    Scotland
    Posts
    11,361
    Well done.
    If there is something that you would like to see in Fantasy Grounds that isn't currently part of the software or if there is something you think would improve a ruleset then add your idea to the wish list http://fg2app.idea.informer.com/

  5. #5
    Had to update this to v2 - I forgot to add back in the "if critical" guard around it. It works now.

  6. #6
    LordEntrails's Avatar
    Join Date
    May 2015
    Location
    GMT -7
    Posts
    8,411
    Blog Entries
    9
    Thanks, just talked with one of my groups tonight and we all agreed to start using this. Thanks!

    Current Projects: Ultimate Undermountain (NYDUM)
    Community Contributions: Gemstones, 5E Quick Ref Decal, Adventure Module Creation, Dungeon Trinkets
    DMsGuild Content: Balance Disturbed (Adventure), Dungeon Room Descriptions
    FG Product Reviews: Virtual Scribe Reviews

  7. #7
    Great job. Nice to have available. I personally love it (as a DM) when people roll two ones plus their modifier on a cirt. Hilarious. As a player... I HATE IT!
    rob2e - Join me on Discord!
    Become a Patron!
    Ultimate License Holder (owner of ALL 5E WotC material, and much more)
    Time Zone: U.S. Pacific (UTC -8 or -7; Check Local Listings)
    Follow me on Twitter
    Come watch the Twitches... twitch.tv/rob2e
    Also my YouTube Channel
    My Dungeon Master's Guild Material

  8. #8
    Does this effect NPC crits as well?

  9. #9
    What rulesets does this work for? Any built on CoreRPG?
    Ultimate License Holder GM

    Games currently Playing: AD&D, DCC RPG and D&D 5e

    Finished Projects: AD&D Ruleset
    New School NPC Maker 5E
    New School NPC Maker PFRPG - 3.5E
    Old School NPC Maker

    Current Projects:

    1) Adventure Module.
    2) Maintaining and improving released projects.
    3) C.O.O.L. Beasts
    4) Basic Fantasy Ruleset
    5) Metamorphosis Alpha Ruleset

  10. #10
    Trenloe's Avatar
    Join Date
    May 2011
    Location
    Denver, Colorado, USA (for a bit)
    Posts
    24,134
    Quote Originally Posted by vodokar View Post
    What rulesets does this work for? Any built on CoreRPG?
    Specifically for 5E.
    FG Con 15 Fantasy Grounds Online RPG Convention - Nov. 8-10, 2019
    Register at www.fg-con.com for all the latest info.

    Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  

Log in

Log in