Originally Posted by
Zaister
After an attack hits, the icon shown in the result entry in the chat window is the roll_attack icon, not the actual roll_attack_hit.
I believe the culprit is line 791 in manager_action_attack.lua, the pattern match does not recognize the text "[HIT vs. xx Defense]" as a hit. I'm not sure why the actualy AC is shown to the players here, so I changed line 646, so that the text inserted in the Messages reads just "[HIT]" (same on line 649 vs CMD). After that the pattern matches, and the correct icon shows up.
I also think the space goblin icons for the various roll_* icons (as well as for the GM portait token) might be outstaying their welcome, now that we do not have goblins in the sidebar anymore. I'd prefer them replaced by something that is more easily distinguishable, like the similar icons in the 3.5e rulset, maybe with a gun icon insterad of a sword, though.