Sounds good, thanks for the updates and all your hard work in this!
I may be able to add here something:
This error is common, you also have this in 3.5e :) It is not possible to drag&drop skill links directly from the character sheet, I am not sure why but probably because the skill descriptions in the character sheet are not copies of the skill descriptions (so this does not work like with items, feats etc. coming from the library). Instead: When you click on the skill pin in the character sheet then FG goes into the skill library and searches for an entry with the same name and then shows its description by opening the entry directly from the library. That's probably the reason why you can't drag&drop the skill description directly from the character sheet because it's just a "mirror" of the original entry (created every time when clicking on it; I mean the original entry in the library will be opened directly) and not really a permanent copy, so no data "to grasp" from within the character sheet because there is no skill description stored :)
(For example: When you first open the skill description directly from the library and then from the character sheet then no second window will be opened, instead the first one will be pushed. Or, when it is a description coming from an official module, such that the skill description can not be edited, then you can also not edit it in the character sheet. These prove that the entries in the sheet are not copies but rather a direct link to the library and therefore a direct drag&drop from the sheet produces this error)
But only assumptions so far, I may be wrong :)
I suspect something similar in PF2?
The PFRPG2 ruleset is based on 3.5E (last years version) so it will share common issues.
The issue is in the code, as a link is a link and should be dragable.
The function header was: function onDragStart(draginfo) which is incorrect - see the API reference here: https://www.fantasygrounds.com/refdo...cp#onDragStart
There was also another issue in the code, once the function header was corrected.
This code now works fine - changes highlighted in bold:
Code:function onDragStart(button, x, y, draginfo)
local v = getSkillDescNode();
if v then
draginfo.setType("shortcut");
draginfo.setIcon("button_link");
draginfo.setShortcutData("referenceskill", v.getNodeName());
draginfo.setDescription(window.label.getValue());
return true;
end
return false;
end
Ahhh, cool, thanks for the insight :) I learned something now :) Never looked at the drag&drop code yet (thus, I only could guess the issue) and therefore very interesting for me what you're writing :) (also because I wanted to look at this Drag&drop stuff once I have time)
EDIT: And thanks for the link, now I will read through this :D
Not sure if a bug, or intended to be added manually, but noticed while creating a Ranger that the level 3 class feature IRON WILL didn't increase Will Save proficiency from Trained to Expert. Was it missed due to the parsing issues, or are class features planned for a future update? Thanks.
There is currently no automation when adding class abilities or feats.
The base class save proficiency ranks are added when the class is added at level 1, but any changes after that need to be done manually.
for the future? See the info about experimental functionality here: https://www.fantasygrounds.com/forum...mber-26th-2019
Hi there Trenloe,
I don't know whether you will try to implement it and I know you have a lot of things to do, but, do you think you could add in the Party Sheet (Skills Tab) the proficiency level of each skill? It is a suggestion. I think it would be useful.
https://www.fantasygrounds.com/forum...4&d=1575732866
Attachment 30704
Yes, it could overload it, but, I don't know, maybe something like this:
https://www.fantasygrounds.com/forum...5&d=1575735370
Attachment 30705
That line would have to be duplicated for each PC - adding about 20-25% in vertical space used for each PC.
Having an indicator is a good idea, as it would be handy for the GM to know the proficiency of some skills, so that minimum proficiency rank checks could be made (manually by the GM just asking the players to make checks for certain PCs), but I don't want to overload the Party Sheet window. I'll look into some form of visual indicator on the bottom of the skill bonus control - maybe similar to the "check" boxes on Paizo character sheets, with boxes filled in to indicate proficiency level, or maybe little letters. I'll see what might work... But it'll be a while yet.