Attack Modifiers Extension

I've created this extension for easier selection of attack/combat modifiers (Charge, Flanking, Cover, etc.). This currently only work in character sheets, not NPC sheets. I might do that later if people want me to.

Forge link: https://forge.fantasygrounds.com/shop/items/305/view

Changelog:
v1.0: Release
v1.1: PFRPG support
v1.2: Support for all base + art subscription themes
v1.21: Hotfix: Readded PFRPG support which was accidentally lost
v1.22: Hotfix: Changed typo, Charge modifier from +1 to +2
v1.3: Compatibility update for ruleset changes
v1.4: Added exclusionsets to use the new ruleset features and add better compatibility
v1.5: Added compatibility with the Extra-Actions extension and changed some behavior in the extension itself
v1.6: Major rewrite
v1.7: Compatibility patch

Here is a short GIF demonstrating before we go into the more technical stuff.
https://i.imgur.com/mXii50K.gif

What this extension does:
- Seperate subwindow above weapon in the actions tab which is only shown in "Combat" mode
- All attack modifiers (all I know of in 3.5E) with the corresponding plus and minus
- Only modifiers which work together can be selected together
- Check wether the attack is melee or ranged (Shoot [into] Melee) doesn't work on melee attacks
- New hopefully bit more modern buttons :) which change on the theme you are using (see below)

What the extension does not yet:
- Extra logic besides attack is currently not working as I'd like it to (e.g. cover giving +2 reflex saves). I will get around that eventually.

Compability: Overwritten data
- Global script ModifierStack overwritten
- campaign/scripts/char_actions.lua overwritten
- minimal join merge in windowclass charsheet_actions
- minimal join merge in windowclass charsheet

Known minor nuisance:
Modifiers are not bound by character sheet but by user. This shouldn't impact actual gameplay but may irritate. Explanation:
https://www.fantasygrounds.com/forum...l=1#post655246

Nice :)

So, basically like a sheet in-built modifiers window (and extended)? :) That keeps some screen real estate and leads to a more compatible version, while the modifier window may have had the advantage that it is also usable for NPCs :)

Quote:

---

Originally Posted by Kelrugem

Nice :)

So, basically like a sheet in-built modifiers window (and extended)? :) That keeps some screen real estate and leads to a more compatible version, while the modifier window may have had the advantage that it is also usable for NPCs :)

---

Yes, it really keeps the focus on the character sheet and players don't have to navigate to the top right (or bottom left if using some other extensions) to open another window, click and close that...
And yeah, I forgot to include some big info in the post :D

please just add the pfrpg to ruleset for use please it is all the same. pf1e was made off 3.5

Quote:

---

Originally Posted by toastsniffer187

please just add the pfrpg to ruleset for use please it is all the same. pf1e was made off 3.5

---

I've added PFRPG as ruleset after reading the PFRPG combat rules. Forge update always take a while to approve.

v1.1
- Added PFRPG ruleset support

Update v1.2
- Added appropriate icons for all base + art subscription themes where needed
- These icons will be changed automatically depending on which theme is loaded, default are the brown ones in the screenshots in 1st post

Hotfix Update v1.21
- Readded PFRPG support which was accidentally removed in the last update

Hi, i've just encountered your extension and trying in it.
Just a thought: in pfrpg charge doesn't apply the -2 to AC, does it?

Also: in pfrpg 1 campaign, charge doesn't give +2, it gives +1
Attachment 49945

Quote:

---

Originally Posted by Urheil

Hi, i've just encountered your extension and trying in it.
Just a thought: in pfrpg charge doesn't apply the -2 to AC, does it?
...
Also: in pfrpg 1 campaign, charge doesn't give +2, it gives +1
Attachment 49945

---

Quote:

---

What the extension does not yet:
- Extra logic besides attack is currently not working as I'd like it to (e.g. cover giving +2 reflex saves). I will get around that eventually.

---

The baseline inbuilt modifiers don't modify things such as AC or saves, thus I haven't implemented such things from the start. I will however try to get them working, probably sometime in the next weeks when I have a bit more time :)

Thanks for pointing out the charge modifier, I hotfixed that.

Hotfix Update v1.22
- Changed typo, Charge modifier from +1 to +2

Update v1.3
- Implemented the modifier system changes from Test channel
- REMOVED: Override of global modifier script as it is no longer needed

Update will be moved to Forge when ruleset updates hit the Live channel.

Any idea if this would trigger the IFTAG check (using Kelrugem's Advanced Effects; otherwise it'd be IF:CUSTOM()) on, say, Flanking? I have some effect magic that checks for a "flanking" effect to give my rogue player sneak attack damage. So if this applies the bonuses via effects it's all good. I'll probably experiment to see, but won't have time until later this week and thought I'd ask.

Quote:

---

Originally Posted by Croddwyn

Any idea if this would trigger the IFTAG check (using Kelrugem's Advanced Effects; otherwise it'd be IF:CUSTOM()) on, say, Flanking? I have some effect magic that checks for a "flanking" effect to give my rogue player sneak attack damage. So if this applies the bonuses via effects it's all good. I'll probably experiment to see, but won't have time until later this week and thought I'd ask.

---

This extension doesn't add any effects, just modifies the attack code and inserts a name into the attack (for example FLANKING +2). Modifiers and effects are separated.
You'd have to press Flanking, then attack. If the attack hits, press sneak attack and press damage.

Problem with near full automation are edge-cases like a monster which is flank immune but not precision damage immune.

Though I'll add sneak attack on my list, like power attack and combat expertise. When sliders (from images) become available, I'll try to implement those things if present as feat or class ability on the charsheet.

Having a separate action for sneak attack damage plays extremely poorly with damage reduction--a scenario way more common than something flank immune but not precision. Adding the sneak attack as an effect applied with type 'precision' when a tag is present means it plays well with both damage reduction and immunity to precision damage.

Quote:

---

Originally Posted by Croddwyn

Having a separate action for sneak attack damage plays extremely poorly with damage reduction--a scenario way more common than something flank immune but not precision. Adding the sneak attack as an effect applied with type 'precision' when a tag is present means it plays well with both damage reduction and immunity to precision damage.

---

I meant a separate effect applied like Sneak Attack; DMG: 1d6 precision for the next action or round. A separate manual damage roll (like fireball damage) of course gets complicated.

https://i.imgur.com/G4XXi94.png

As I said in the post before, when image UI elements become public I'll try to add things like power attack, combat expetise, sneak attack and so on into the attack modifiers.

My rogue gets a bit complicated, so I've tried to simplify it for her by making it so she only has to select the one effect that gives her the extra damage. Like, she has Outflank, sliding dash, scout's charge, skirmisher, each with different total bonuses. So managing the state of her effects was getting a bit, well, error-prone? So I made it "simple" by setting it up to only have to do the one effect that reflects what the character actually did. If that makes sense. Here, I'll show.


Attachment 50258

Update v1.3 is live in Forge.
v1.3: Compatibility update for ruleset changes

Update v1.4

• Added exclusionsets to use the new ruleset features and add better compatibility
• Slightly increased charsheet width to show all labels on minimum size
• Slightly adjusted the theme detection

Also live on Forge.

Update v1.5

• Added compatibility with the Extra-Actions extension and changed some behavior in the extension itself

Hey thank you very much for this mod. Looks amazing and great idea. Just downloaded it to try it out and am receiving this error message. I do have a few other mods loaded so maybe it is conflicting but otherwise I am trying to use it through Pathfinder.

Attachment 51415

Edit: Additional note, nothing is showing up on the character sheet at all, if that helps. Any idea what the issue could be or should I start unloading mods.

Quote:

---

Originally Posted by Hoss

Hey thank you very much for this mod. Looks amazing and great idea. Just downloaded it to try it out and am receiving this error message. I do have a few other mods loaded so maybe it is conflicting but otherwise I am trying to use it through Pathfinder.

Attachment 51415

Edit: Additional note, nothing is showing up on the character sheet at all, if that helps. Any idea what the issue could be or should I start unloading mods.

---

Hi,

this comes from an incompatibility with Zygmunts Extra Actions (which didn't find it's way until into the proper channel). Zygmunt has fixed it and after an update, everything should be working as intended.

See here:
https://www.fantasygrounds.com/forum...l=1#post639697

I am in a campaign running 2 characters. any check boxes I make on 1 are mirrored on all other characters I control, mildly annoying but by no means a major issue.

Attachment 53464

click a box on the left character and it checks on the right as well

Quote:

---

Originally Posted by Morenu

I am in a campaign running 2 characters. any check boxes I make on 1 are mirrored on all other characters I control, mildly annoying but by no means a major issue.

Attachment 53464

click a box on the left character and it checks on the right as well

---

Thanks for reporting. This behavior seems as suspected because modifiers work independent of character/npc sheets. You could press a modifier on the character sheet and roll via a NPC and the NPC would use the modifier. The modifiers are not bound to the character sheet but the session/actual connected user.
I don't know if/how I can change this. I'll let you know if this has changed.
In the meantime, I can edit the initial post and Forge description to give some explanation about this behavior.

An update for this extension after the July ruleset update is not needed and there are no known issues.

If you experience issues, please post in this thread with as much information as you can.

v1.6 Major rewrite

Added

• Extension icon (contributed by SirMotte thanks!)

Changed

• Replaced the checkmark graphics to CoreRPG buttons. The extension can now be used with pretty much every theme out there
• Replaced the spellmode toggling with an expand/collapse icon toggle
• Rewritten the compatibility code for FG-Extra-Actions to work again after the updates in that extension
• Future-proofing some code for better general compatiblity

v1.7 Compatibility patch

Changed

• Compatibility to other extensions

No change was needed for the Feb-2023 ruleset update for this extension.